fix: error handling in Sequence#130
Merged
Merged
Conversation
bajtos
force-pushed
the
fix/error-handling
branch
from
May 20, 2019 10:12
d999f69 to
d3b0b7b
Compare
Rework the code handling authentication errors to correctly preserve stack trace of the original error, instead of creating a new error instance with a stack pointing to the Sequence class only. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
bajtos
force-pushed
the
fix/error-handling
branch
from
May 20, 2019 10:13
d3b0b7b to
e8c60b1
Compare
hacksparrow
approved these changes
May 20, 2019
raymondfeng
approved these changes
May 20, 2019
nabdelgadir
approved these changes
May 21, 2019
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the code handling authentication errors to correctly preserve stack trace of the original error, instead of creating a new error instance with a stack pointing to the Sequence class only.